Shop/Shop-Storefront
4
0
Fork 0
Code Issues 22 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

feat: add medusa starter design hero banner #13

Merged
yen.nguyen merged 3 commits from namds/implement-hero-banner into main 2025-12-19 08:04:11 +00:00
Conversation 1 Commits 3 Files Changed 20
+751 -39
Ghost commented 2025-12-16 08:15:25 +00:00
Copy Link
Copy Source

feat: add hero banner for vibentec design
feat: add CTA banner vibentec design and create carousel image display

feat: add hero banner for vibentec design feat: add CTA banner vibentec design and create carousel image display
Ghost added 1 commit 2025-12-16 08:15:25 +00:00
feat: add medusa starter design hero banner 9e0f6b0071 
feat: add hero banner for vibentec design
feat: add CTA banner vibentec design and create carousel image display
Ghost added 1 commit 2025-12-17 04:12:41 +00:00
feat: create design for 3bear and drsquatch hero banner, create variants cta section 7afffb3f99
Ghost added this to the Storefront Shop project 2025-12-17 04:19:08 +00:00
duc.vi was assigned by Ghost 2025-12-17 04:19:13 +00:00
yen.nguyen was assigned by Ghost 2025-12-17 04:19:13 +00:00
Stephan was assigned by Ghost 2025-12-17 04:19:13 +00:00
yen.nguyen requested changes 2025-12-17 19:38:52 +00:00
src/modules/layout/templates/vt-cta-banner/bear-cta.tsx Outdated
@@ -0,0 +1,35 @@
"use client"
yen.nguyen commented 2025-12-17 19:38:35 +00:00
Owner
Copy Link
Copy Source

I think this file and also the component inside should have other name :)

I think this file and also the component inside should have other name :)
yen.nguyen marked this conversation as resolved
src/modules/layout/templates/vt-cta-banner/index.tsx Outdated
@@ -0,0 +18,4 @@
const variants: Record<string, any> = {
default: DefaultCtaBanner,
"3bear": BearCtaBanner,
yen.nguyen commented 2025-12-17 19:37:49 +00:00
Owner
Copy Link
Copy Source

Please think of another name for this variant (and also the corresponding component) as 3bear is neither a brand of us or a partner brand

Please think of another name for this variant (and also the corresponding component) as 3bear is neither a brand of us or a partner brand
yen.nguyen marked this conversation as resolved
Ghost added 1 commit 2025-12-19 03:11:03 +00:00
refactor: combine 3bear cta section into dynamic cta section a2e5b56eb8
yen.nguyen merged commit 389cf1c856 into main 2025-12-19 08:04:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
yen.nguyen
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Storefront Shop
Assignees
Clear assignees
claude-code duc.vi (Vi Van Duc) Gingerthu Stephan yen.nguyen (Yen Nguyen)
No Assignees duc.vi yen.nguyen Stephan
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Shop/Shop-Storefront#13
Delete Branch "namds/implement-hero-banner"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?