Shop
/
Shop-Storefront
4
0
Fork 0
Code Issues 25 Pull Requests Packages Projects 1 Releases Wiki Activity

namds/refactor-base-layout #8

Merged
yen.nguyen merged 27 commits from namds/refactor-base-layout into main 2025-12-15 07:44:38 +00:00
Conversation 0 Commits 27 Files Changed 58 +5248 -38
yen.nguyen commented 2025-12-08 10:34:43 +00:00
Owner
Copy Link
No description provided.
yen.nguyen added 24 commits 2025-12-08 10:34:43 +00:00
51d6ee2051 feat(layout-system basics): Added component-map, component-props, configloader and renderer. 
Added vt-template for nav and poc example footer.
Added ste.medusa-starter.design.json.
Probable starting point (main)/layout.tsx refactored to use dynamic layout renderer instead of hardcoded template.
39fe0c81e5 added packages to support markdown 
added dummy pages for about and contact.
updated tailwind.config.js to include config/*.json to scan for classes.
refactored system basics. Removed component-props, using generic LayoutComponentDefinition and LayoutContext. cleanup component-map. Updated renderer to be more failsafe.

new abstracted components:
 vt-mega-menu,
vt-sidemenu,
vt-banner with 3 variants,
vt-header,
vt-homebutton,
vt-cartbutton,
vt-accountbutton,
vt-linkbutton,
yen.nguyen requested review from duc.vi 2025-12-08 10:45:19 +00:00
yen.nguyen reviewed 2025-12-09 22:19:15 +00:00
yen.nguyen left a comment
Author
Owner
Copy Link
  • By each single small html component we have to create a .tsx Component with no improvement, it is only a html copied-version -> this is very time-consuming. Need to improve this.
- By each single small html component we have to create a .tsx Component with no improvement, it is only a html copied-version -> this is very time-consuming. Need to improve this.
src/app/[countryCode]/(main)/vt-about/page.tsx
@ -0,0 +1,12 @@
import React from "react";
yen.nguyen commented 2025-12-09 21:28:35 +00:00
Author
Owner
Copy Link

This file is a route --> file name should be /about instead of /vt-about?

This file is a route --> file name should be /about instead of /vt-about?
namds29 commented 2025-12-10 09:07:44 +00:00
Member
Copy Link

this is for testing purpose, i'll refactor later when we do this page

this is for testing purpose, i'll refactor later when we do this page
yen.nguyen marked this conversation as resolved
src/app/[countryCode]/(main)/vt-contact/page.tsx
@ -0,0 +1,12 @@
import React from "react";
yen.nguyen commented 2025-12-09 21:30:24 +00:00
Author
Owner
Copy Link

same problem as with /vt-about, Is it for testing purpose only?

same problem as with /vt-about, Is it for testing purpose only?
namds29 commented 2025-12-10 09:08:14 +00:00
Member
Copy Link

this is for testing purpose, i'll refactor later when we do this page

this is for testing purpose, i'll refactor later when we do this page
yen.nguyen marked this conversation as resolved
src/modules/layout/components/vt-cartbutton/index.tsx
@ -0,0 +24,4 @@
href="/cart"
data-testid="nav-cart-link"
>
Cart (0)
yen.nguyen commented 2025-12-09 21:59:40 +00:00
Author
Owner
Copy Link

Need data binding improvement

Need data binding improvement
namds29 commented 2025-12-10 09:23:53 +00:00
Member
Copy Link

this part is component of medusajs we just clone it follow folder templates/nav/index. the data binding already implement below your highlight code, this is only the fallback when having any error of data response so will return this component

this part is component of medusajs we just clone it follow folder templates/nav/index. the data binding already implement below your highlight code, this is only the fallback when having any error of data response so will return this component
yen.nguyen marked this conversation as resolved
namds29 added 1 commit 2025-12-10 07:10:13 +00:00
yen.nguyen removed review request for duc.vi 2025-12-10 11:24:12 +00:00
namds29 added 2 commits 2025-12-11 05:59:27 +00:00
yen.nguyen merged commit 07a52dca2b into main 2025-12-15 07:44:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Shop/Shop-Storefront#8
No description provided.
Delete Branch "namds/refactor-base-layout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?